brutile Issue Tracker Rss Feed

Closed Issue: MemoryCache TouchPermaCache issue [4183]

pauldendulk — Wed, 24 Apr 2013 16:39:11 GMT

Commented Issue: MemoryCache TouchPermaCache issue [4183]

pauldendulk — Wed, 24 Apr 2013 16:38:07 GMT

Hello Paul,
We have a problem with the method CleanUp of MemoryCache.
Lowest level (best quality) of our provider's schema is levelId = 0. So, the cache is quickly filled with tiles of this resolution and TouchPermaCache() avoids oldest tiles deletion.

the test :
if (index.LevelId == "0")
could be replace by
if (index.LevelId == LevelIdToPreserve)
where LevelIdToPreserve would be a public property of the memory cache.

Regards,
Pierre
Comments: I added an optional 'Func<TileIndex, bool> keepTileInMemory' that determines whether a tile should not be cleaned up. This gives the user all possible options. The old implementation (index.level == 0) could be implemented with: (index) => index.level == 0. But this method could also be used to preserve a certain area which you know is important to your application. It is used in a test here: https://brutile.codeplex.com/SourceControl/changeset/7a8fb2a92776#file_diff_BruTile.Tests/Cache/MemoryCacheTest.cs

Closed Issue: UserAgent not set in RequestHelper [4190]

pauldendulk — Wed, 24 Apr 2013 13:34:00 GMT

Commented Unassigned: Using invariant paths in FileCache.cs [4189]

pauldendulk — Wed, 24 Apr 2013 10:40:23 GMT

Please compose OS independent file paths in the FileCache.cs class:

E.g. use
```
public string GetFileName(TileIndex index)
{
return Path.Combine(GetDirectoryName(index), string.Format("{0}.{1}", index.Row, _format));
}
```
instead of Windows-only paths like

```
public string GetFileName(TileIndex index)
{
return string.Format(CultureInfo.InvariantCulture,
"{0}\\{1}.{2}", GetDirectoryName(index), index.Row, _format);
}
```
wherever such paths are created.
Comments: okay. We just started using BruTile in Xamarin.iOS, so you fixed a bug for us too. Please let us know if you find any other platform dependent issues.

Closed Issue: MemoryLeak in SharpMap implementation [4184]

pauldendulk — Wed, 24 Apr 2013 09:06:08 GMT

I think this only occurs when using GDI+. I need to check.

Peter provided a patch for this.
Comments: applied the patch months ago

Commented Unassigned: Using invariant paths in FileCache.cs [4189]

StSquare — Wed, 24 Apr 2013 08:27:34 GMT

Please compose OS independent file paths in the FileCache.cs class:

E.g. use
```
public string GetFileName(TileIndex index)
{
return Path.Combine(GetDirectoryName(index), string.Format("{0}.{1}", index.Row, _format));
}
```
instead of Windows-only paths like

```
public string GetFileName(TileIndex index)
{
return string.Format(CultureInfo.InvariantCulture,
"{0}\\{1}.{2}", GetDirectoryName(index), index.Row, _format);
}
```
wherever such paths are created.
Comments: You are welcome, thanks for fixing. I'm using BruTile with SharpMap on a Mac for a gtk# application. Kind regard, Stefan

Closed Issue: fix setup to work with different project types [4181]

pauldendulk — Wed, 24 Apr 2013 07:43:52 GMT

Currently BruTille supports three different project types. desktop, Silverlight and WP7. These types have separate csproj files and separate sln files. The csproj file are in the same directory. They compile to different output directories, ., .\SL and .\WP. But they output their obj files to the same directory. This causes compile errors if you alternately compile different types, unless you do a Clean in between.

If the csproj files are in different directories the bin and obj files are automatically output to different directories. Keeping projects in sync is a bit harder in this case, because you have to add files by reference and have to browse to different directory to add them.

To fix the problem we cause configure the csproj to output their obj's to different directories or we could work with project files in different directories.

Comments: We now work with PCL on .net 4.0.3. This works well, but we also build for .net 4.0 (not pcl) and 3.5 (all from the same csproj file).

Closed Issue: implement MBTiles [4185]

pauldendulk — Wed, 24 Apr 2013 07:37:42 GMT

Felix has added support for MBTiles.

I made some modification to get it work with custom tile schema's.

Some remarks on my changes:
- I added constructor arguments for a specific TileSchema. This is what I use for the RD projection/schema.
- There are now 3 ways to specify a schema
1) the default MBTiles schema is assumed when nothing is specified.
2) specified in the constructor
3) through the 'map' table that is used in the haiti sample.
- I now assume the extent is in the projection of the TileSchema. So in the case of regular MBTiles it needs to be in SphericalMercator.
- I have not implemented this yet, so I just left this as a todo.
- Reading the extents of the tiles per layer is slow. But this now only happens when there is a 'map' table. Perhaps it could be improved with indexes.
- The bbox per layer (used as an optimization in MBTiles) is also required by WMTS. We should prepare for this so MBTiles needs no custom code for this.
- I added a none 'type' (base|overlay). You can no specify the type in the constructor. When no type is specified it is read from the 'metadata' table.
- I did not test MBTiles in Silverlight.
Comments: not an issue

Closed Unassigned: Using invariant paths in FileCache.cs [4189]

pauldendulk — Wed, 24 Apr 2013 07:26:06 GMT

Please compose OS independent file paths in the FileCache.cs class:

E.g. use
```
public string GetFileName(TileIndex index)
{
return Path.Combine(GetDirectoryName(index), string.Format("{0}.{1}", index.Row, _format));
}
```
instead of Windows-only paths like

```
public string GetFileName(TileIndex index)
{
return string.Format(CultureInfo.InvariantCulture,
"{0}\\{1}.{2}", GetDirectoryName(index), index.Row, _format);
}
```
wherever such paths are created.
Comments: fixed in last commit: https://brutile.codeplex.com/SourceControl/changeset/c06fd0cc2432

Commented Unassigned: Using invariant paths in FileCache.cs [4189]

pauldendulk — Wed, 24 Apr 2013 07:25:32 GMT

Commented Issue: UserAgent not set in RequestHelper [4190]

pauldendulk — Sun, 21 Apr 2013 15:38:53 GMT

Commented Issue: UserAgent not set in RequestHelper [4190]

pauldendulk — Sun, 21 Apr 2013 13:34:24 GMT

UserAgent and referer is not longer set in RequestHelper when using the method
public static byte[] FetchImage(Uri uri, string userAgent, string referer, bool keepAlive)

This means problems with server that verify that a correct referer is set

Comments: Reflection would probably work but but it feels a bit like a hack. I just committed a possible solution that: - removes the FetchImage methode with useragent, referer en keepalive as parametrs. - adds a FetchImage that takes a WebRequest as parameter (that could be initialized with those parameters). - adds a WebRequestFactory method as parameter to the WebTileProvider constructor. All TileSources that use the WebTileProvider should also include the WebRequestFactory as a constructor parameter. I haven't done that yet.

Commented Issue: UserAgent not set in RequestHelper [4190]

petlof — Sat, 20 Apr 2013 08:07:51 GMT

UserAgent and referer is not longer set in RequestHelper when using the method
public static byte[] FetchImage(Uri uri, string userAgent, string referer, bool keepAlive)

This means problems with server that verify that a correct referer is set

Comments: What about doing some reflection instead? Reflection should be available in PLC from my understanding and this code will set the UserAgent and Referer on those platforms where the WebRequest object has such property. === Add to .ctor() static System.Reflection.PropertyInfo _UAProp = null; static System.Reflection.PropertyInfo _RefererProp = null; static RequestHelper() { Type t = typeof(HttpWebRequest); _UAProp = t.GetProperty("UserAgent"); _RefererProp = t.GetProperty("Referer"); } === Code in FetchImage if (_UAProp != null && !string.IsNullOrEmpty(userAgent)) { _UAProp.SetValue(webRequest, userAgent, null); } if (_RefererProp != null && !string.IsNullOrEmpty(referer)) { _RefererProp.SetValue(webRequest, referer, null); }

Commented Issue: UserAgent not set in RequestHelper [4190]

pauldendulk — Fri, 19 Apr 2013 21:09:14 GMT

Edited Issue: UserAgent not set in RequestHelper [4190]

pauldendulk — Fri, 19 Apr 2013 21:06:00 GMT

Created Unassigned: UserAgent not set in RequestHelper [4190]

petlof — Fri, 19 Apr 2013 17:10:11 GMT

Created Unassigned: Using invariant paths in FileCache.cs [4189]

StSquare — Wed, 17 Apr 2013 14:26:45 GMT

Commented Issue: fix setup to work with different project types [4181]

pauldendulk — Fri, 20 Jul 2012 07:36:14 GMT

Currently BruTille supports three different project types. desktop, Silverlight and WP7. These types have separate csproj files and separate sln files. The csproj file are in the same directory. They compile to different output directories, ., .\SL and .\WP. But they output their obj files to the same directory. This causes compile errors if you alternately compile different types, unless you do a Clean in between.

If the csproj files are in different directories the bin and obj files are automatically output to different directories. Keeping projects in sync is a bit harder in this case, because you have to add files by reference and have to browse to different directory to add them.

To fix the problem we cause configure the csproj to output their obj's to different directories or we could work with project files in different directories.

Comments: Brad, what would be the best way to go about this? A build.txt file in the root? I do mention it on the main page in the news item on PCL.

Closed Issue: Change mapnic to mapnik [4188]

pauldendulk — Fri, 20 Jul 2012 07:27:49 GMT

Commented Issue: Change mapnic to mapnik [4188]

pauldendulk — Fri, 20 Jul 2012 07:27:26 GMT

Just feeling my way around brutile and Hg on windows, I noted that the default is "mapnic", which I think should be "mapnik" (http://mapnik.org/).

A trivial patch is attached to implement the rename.
Comments: With Mercurial a pull request is the 'proper way' they told me. So that is what I prefer. Also, you get the original committers name in the change set, that is nice http://brutile.codeplex.com/SourceControl/changeset/02dac6505978